[api-minor] Fix the return value of PDFDocumentProxy.getViewerPreferences when no viewer preferences are present (PR 10738 follow-up)
#11806
Conversation
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/85f99ee0965e0f3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/789de3d0f22d906/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/789de3d0f22d906/output.txt Total script time: 2.06 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/85f99ee0965e0f3/output.txt Total script time: 2.67 mins
|
|
Looks good to me pending a rebase. |
…ences` when no viewer preferences are present (PR 10738 follow-up) This patch fixes yet another instalment in the never-ending series of "what the *bleep* was I thinking", by changing the `PDFDocumentProxy.getViewerPreferences` method to return `null` by default. Not only is this method now consistent with many other API methods, for the data not present case, but it also avoids having to e.g. loop through an object to check if it's actually empty (note the old unit-test).
Snuffleupagus
force-pushed
the
pr-10738-followup
branch
from
15036a7
to
746eaf3
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8af5f465acf8a3a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/bba2ae00f703628/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/8af5f465acf8a3a/output.txt Total script time: 2.77 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/bba2ae00f703628/output.txt Total script time: 4.30 mins
|
|
Thanks! |
This patch fixes yet another instalment in the never-ending series of "what the *bleep* was I thinking", by changing the
PDFDocumentProxy.getViewerPreferencesmethod to returnnullby default.Not only is this method now consistent with many other API methods, for the data not present case, but it also avoids having to e.g. loop through an object to check if it's actually empty (note the old unit-test).